[superkelle]

Hi I wonder why I need a double naming for a dictionary value, when IO wont to update it on runtime. My dict now looks like this:

FoamFile
{
    version     2.0;
    format      ascii;
    class       dictionary;
    location    "system";
    object      plasmaTuningDict;
}
// * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * //


R      R [1 2 -3 0 0 -2 0] 1320.0;

Vmax     Vmax [1 2 -3 0 0 -1 0] 1000.0;

// ************************************************************************* //

In createFields.H I loaded it like this:

IOdictionary plasmaTuningDict
    (
        IOobject
        (
            "plasmaTuningDict",
            runTime.system(),
            mesh,
            IOobject::MUST_READ_IF_MODIFIED,
            IOobject::NO_WRITE
        )
    );
    

    dimensionedScalar R
    (
        "R",
        dimensionSet(1, 2, -3, 0, 0, -2, 0),
        plasmaTuningDict.lookup("R")
    );
       
    dimensionedScalar Vmax 
    (
        "Vmax", 
        dimensionSet(1, 2, -3, 0, 0, -1, 0), 
        plasmaTuningDict.lookup("Vmax")
    );

In my solver I use following for updating:

R = plasmaTuningDict.lookup("R");
Vmax = plasmaTuningDict.lookup("Vmax");

If I don't do this double naming like:

R     [1 2 -3 0 0 -2 0] 1320.0;

Vmax    [1 2 -3 0 0 -1 0] 1000.0;

I get an error:

wrong token type - expected word, found on line 19 the punctuation token '['

file: /home/kelle/OpenFOAM/kelle-7/run/plasmaTestCase8/plasmaSimulation/system/plasmaTuningDict.R at line 19.

    From function Foam::Istream& Foam::operator>>(Foam::Istream&, Foam::word&)
    in file primitives/strings/word/wordIO.C at line 74.

FOAM exiting

It is just out of interest,. (and it looks a little bit stupid so it would be nice if there is a way to name it just once in the dict)

[wangsen992]

Hi there,

I did some digging and this is an interesting question. I think the problem is that, when you initialized your dimensionedScalar R and Vmax, you used the constructor method,

dimensioned(const word &name, const dimensionSet & dims, const Istream &is)

which is actually a currently deprecated constructor method since 2018-11.

When you call

R = plasmaTuningDict.lookup("R")

, it again returns an Istream object from the dictionary containing the line

[1 2 -3 0 0 -2 0] 1320.0

, then this assignment is actually called with

dimensioned(Istream &is)

which is also deprecated since 2018-11.

If you trace it to the documentation here, you will see that expects the Istream to contain (name, dimensions, value). Since you don't have name, then dimensions will be parsed as a name which causes the problem.

And if you don't want to have the stupid double name, you can use the constructor methods from [7-12/15] which all provides the optional input for name and dims. Probably the easiest one is just [7/15] where you can simply do

dimensionedScalar R ( dict.lookup('R'))

since i believe the return type is a child class of entry so it should work by automatically parsing the ITstream to a entry object. And then update following your original code.

[superkelle]

Thank you for your advise and your time. I forgot to say that this was tested with OF7.

So now it is working without double naming, it is interesting what I think use to work but does not, and what does. So I deleted the entrys in createFields so that only the IO dict was constructed and initialized like above. And then I construct and initialize the Vmax and R in the time loop, so it goes out of scope every cycle and a new Vmax and R get constructed. Then you can construct it like:

dimensionedScalar Vmax 
    (
        "Vmax", 
        dimensionSet(1, 2, -3, 0, 0, -1, 0), 
        plasmaTuningDict.lookup("Vmax")
    );
Info << Vmax << endl;
dimensionedScalar R
    (
        "R",
        dimensionSet(1, 2, -3, 0, 0, -2, 0),
        plasmaTuningDict.lookup("R")
    );
Info << R << endl;

You can omit the dimensionSet entry, but the name entry "R" is mandatory.
So you are just not allowed to construct it out of the time loop and you are fine. What does not work is to construct it like:

dimensionedScalar R
    (
        plasmaTuningDict.lookup("R")
    );

Then I get again:

 --> FOAM FATAL IO ERROR: 
wrong token type - expected word, found on line 21 the punctuation token '['

file: /home/kelle/OpenFOAM/kelle-7/run/plasmaTestCase12/plasmaSimulation/system/plasmaTuningDict.Vmax at line 21.

    From function Foam::Istream& Foam::operator>>(Foam::Istream&, Foam::word&)
    in file primitives/strings/word/wordIO.C at line 74.

FOAM exiting

If I understand it correct in 7/15, it needs a primitive "e"

dimensioned            (           const primitiveEntry &            e)

But If I understand it correct a primitive is nothing else than a pair of a key and again a stream. So you have always to give the name as the key.
https://www.openfoam.com/documentati...tiveEntry.html

I am no pro in OF and C++, so feel free to correct me ^^.