[dinhanh]

Hi everyone, I am new in CFD. I try to make a simple udf: DEFINE_SOURCE as below. But when complied show the error.

#include "udf.h"
#include "math.h"
#include "sg.h"
#include "sg_mphase.h"
#include "flow.h"
#include "mem.h"
#include "metric.h"

#define Cpl 4184
#define Cpv 2014
#define h0l 1143000
#define h0v 1982000
#define Rb 0.000001
#define anuc 0.0005
#define Fvar 50
#define Fcond 0.01
#define pk 22130000
#define Tk 647.31
#define a 7.21379
#define b 0.00001152
#define c -0.000000004787
#define d 483.16
#define Rhol 998.6
#define Rhov 0.02435

DEFINE_SOURCE(energy_source, c, t, dS, i)
{

real Pv;
real dp;
real me;
real mc;
real L;
real source;
int liquid=0;
int vapor =1;
Thread *phase1;
Thread *phase2;
phase1=THREAD_SUB_THREAD(t,liquid);
phase2=THREAD_SUB_THREAD(t,vapor );

Pv=pk*exp((1.0-Tk/C_T(c,t))*(a+(b+c*C_T(c,t))*(C_T(c,t)-d)*(C_T(c,t)-d)));
voidf=C_VOF(c,phase2);
dp =C_P(c,t)-Pv;
if(dp<0)
{
me=Fvar*3.0*anuc*(1.0-voidf)*Rhov*sqrt(2.0*abs(dp)/Rhol/3.0)/Rb;
mc=0.0;
}
else
{
mc=Fcond*3.0*voidf*Rhov*sqrt(2.0*abs(dp)/Rhol/3.0)/Rb;
me=0.0;
}
L=(Cpv*C_T(c,t)+h0v)-(Cpl*C_T(c,t)+h0l);
source=-L*(me-mc);
dS[i]=0.0
return source;

}

Program error message

for d in lnamd64/[23]*; do \
( \
cd $d; \
for f in ../../src/*.[ch] ../../src/makefile; do \
if [ ! -f `basename $f` ]; then \
echo "# linking to" $f "in" $d; \
ln -s $f .; \
fi; \
done; \
echo ""; \
echo "# building library in" $d; \
if [ "" = "1" ]; then \
echo "# using gcc64"; \
make ARCHC=gcc64 -k>makelog 2>&1; \
else \
if [ "" = "1" ]; then \
echo "# using gcc"; \
make ARCHC=gcc -k>makelog 2>&1; \
else \
make -k>makelog 2>&1; \
fi; \
fi;\
cat makelog; \
) \
done
# linking to ../../src/Energy_source.c in lnamd64/3d

# building library in lnamd64/3d
make[1]: ディレクトリ `/home/CFb/CFb003/Exp_Data/Energy_effect/libudf1/lnamd64/3d' に入ります
# Generating udf_names.c because of makefile Energy_source.c
make[2]: ディレクトリ `/home/CFb/CFb003/Exp_Data/Energy_effect/libudf1/lnamd64/3d' に入ります
make libudf.so "CFLAGS=-D_lnamd64 -D_GNU_SOURCE -fpic -shared -ansi -Wall -O -DPTR_RESTRICT= " "LDFLAGS=-shared -lm"
make[3]: ディレクトリ `/home/CFb/CFb003/Exp_Data/Energy_effect/libudf1/lnamd64/3d' に入ります
# Compiling udf_names.o because of udf_names.c
cc -D_lnamd64 -D_GNU_SOURCE -fpic -shared -ansi -Wall -O -DPTR_RESTRICT= -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/`expr "\`pwd\`" : '.*/\(.*\)/[23].*'`/`basename "\`pwd\`"` -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/src -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/cortex/src -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/client/src -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/tgrid/src -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/multiport/src -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/multiport/mpi_wrapper/include -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/multiport/mpi_wrapper/src -I. -c udf_names.c
# Compiling Energy_source.o because of Energy_source.c
cc -D_lnamd64 -D_GNU_SOURCE -fpic -shared -ansi -Wall -O -DPTR_RESTRICT= -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/`expr "\`pwd\`" : '.*/\(.*\)/[23].*'`/`basename "\`pwd\`"` -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/src -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/cortex/src -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/client/src -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/tgrid/src -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/multiport/src -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/multiport/mpi_wrapper/include -I/ap/ANSYS/ansys_inc/v145/fluent/fluent14.5.7/multiport/mpi_wrapper/src -I. -c Energy_source.c
Energy_source.c:26: error: expected ‘;’, ‘,’ or ‘)’ before ‘-’ token
make[3]: *** [Energy_source.o] エラー 1
make[3]: ターゲット `libudf.so' はエラーにより再 make できませんでした.
make[3]: ディレクトリ `/home/CFb/CFb003/Exp_Data/Energy_effect/libudf1/lnamd64/3d' から出ます
make[2]: *** [lnamd64] エラー 2
make[2]: ディレクトリ `/home/CFb/CFb003/Exp_Data/Energy_effect/libudf1/lnamd64/3d' から出ます
make[1]: *** [default] エラー 2
make[1]: ディレクトリ `/home/CFb/CFb003/Exp_Data/Energy_effect/libudf1/lnamd64/3d' から出ます


How could I fix this error? Plese help, thank you in advance!!!

[pakk]

The problem is that you use the variable "c" two times.

Once in your definition in line 21, where you define it as a number. And the second time in line 26, where you define it as a variable.

You line 21 tells to the compiler: "every time I write the letter c, replace it by the number -0.000000004787".
So when the compiler reaches line 26, it reads:

DEFINE_SOURCE(energy_source, -0.000000004787, t, dS, i)

And that does not make any sense, since a variable name is expected there. Once the compiler reads the minus sign, it knows there is a problem, so that explains your error.

Edit: To solve it, you should rename one of the two c's. I would advice to rename the first one (in line 21), but either option works.

[upeksa]

You have defined "c" twice: as a constant and as a cell_t type argument in DEFINE_SOURCE.

Check this line: dS[i]=0.0;

Cheers

[dinhanh]

Thank you very much, Upeksa and Pakk