[skaal]

I want to collect collision statistics from a lagrangian cloud. For that purpose I need to access the individual parcels in that cloud.



In OpenFOAM-8 I would just create the cloud object and iterate over the parcels:

// openFOAM-8

basicReactingMultiphaseCloud parcels("cloudName", rho, U, g, slgThermo);
forAllIter(basicReactingMultiphaseCloud, parcels, iter)
{ ... }

Since, in OF-10, the cloud object is created by the corresponding fvModel, I do not need create it in the solver myself but can look it up from the object registry. As a side note: I want to do this because the cloud constructor otherwise tries to read the corresponting properties dict from constant -- and all entries must be defined in there, there is no longer an active flag to just switch the cloud off.

// OpenFOAM-10

reactingMultiphaseCloud& parcels = mesh.template lookupObjectRef<reactingMultiphaseCloud>("cloudName");
forAllIter(typename reactingMultiphaseCloud, parcels, iter)
{ ... }

This fails to compile with the error message:

/home/user/OpenFOAM/OpenFOAM-10/src/OpenFOAM/lnInclude/objectRegistryTemplates.C:182:61:error: reference to ‘Foam::ParcelCloud<Foam::ReactingMultiphaseClou
d<Foam::ReactingCloud<Foam::ThermoCloud<Foam::MomentumCloud<Foam::ParcelCloudBase<Foam::ReactingMultiphaseParcel<Foam::ReactingParcel<Foam::ThermoParcel<Foa
m::MomentumParcel<Foam::particle> > > > > > > > > >::typeName’ is ambiguous 
  182 |             << " successful\n    but it is not a " << Type::typeName

I dug around a bit and found a code snipped in

src/lagrangian/parcel/submodels/ReactingMultiphase/StochasticCollision/SuppressionCollision/Suppression
Collision.C

which would use the parcelCloud as data type. Doing this

// OpenFOAM-10

parcelCloud& parcels = mesh.template lookupObjectRef<parcelCloud>("cloudName");
forAllIter(typename reactingMultiphaseCloud, parcels, iter)
{ ... }

I do not have access to various member functions, e.g.:

error: ‘class Foam::parcelCloud’ has no member named ‘composition’ 
  151 |             label idSolid =  parcels.composition().idSolid();

I found this post using the object registry to access a particle cloud with a very similar issue in an old(er) OpenFOAM version. However, I have no idea how to adapt the solution in my case.
Since reactingMultiphaseCloud is just a typedef, inserting the full template does not make a difference.


Does anyone have an idea on how to solve this?

[olesen]

I did not check with any of the .org versions, but in the openfoam.com versions I know that it is no problem to just use the forAllIters and forAllConstIters macros (note the additional trailing 's' ) and traverse the cloud parcels.


You could try just using the equivalent of what the forAllConstIters does and simply use a range-for. Eg,

for (const auto& p : parcels)
 {
    // do something
 }

[skaal]

Thanks for the ideas but sadly neither of your suggestions solves the issue:

• forAllIters is not available in the .org version
• the for (const auto& p : parcel) indeed does the same thing as for forAllIter, and thus throws the same error message...

[olesen]

which error messages exactly?

[skaal]

Hi Mark, sorry for the late reply.


To summarize things more thoroughly:

• forAllIters is not available:
  error: ‘forAllIters’ was not declared in this scope; did you mean ‘forAllIter’?
  15 | forAllIters(reactingMultiphaseCloud, parcels, iter)
• creating the cloud as reactingMultiphaseCloud:
  reactingMultiphaseCloud& parcels = mesh.template lookupObjectRef<reactingMultiphaseCloud>("cloudNam e");
  
  I get the already mentioned issue with ambiguous typeNames:
  OpenFOAM/OpenFOAM-10/src/OpenFOAM/lnInclude/objectRegistryTemplates.C:182:61:error: reference to ‘Foam::ParcelCloud<Foam::ReactingMultiphaseClou
  d<Foam::ReactingCloud<Foam::ThermoCloud<Foam::Mome ntumCloud<Foam::ParcelCloudBase<Foam::ReactingMult iphaseParcel<Foam::ReactingParcel<Foam::ThermoParc el<Foa
  m::MomentumParcel<Foam:article> > > > > > > > > >::typeName’ is ambiguous
  182 | << " successful\n but it is not a " << Type::typeName
  
  It does not matter, if I loop over the parcels using forAllIter or via a for each loop as you suggested, the error message is the same.
• The only variant that seems to work is to create the cloud directly via calling the constructor:
  reactingMultiphaseCloud parcels("cloudName", rho, U, g, thermo);
  

[skaal]

Just for reference: I solved this issue now by wrapping the collision statistics in an extra model which reads the cloudProperties file only when it is present.
Internally that model wraps the reactingMultiphaseCloud in an autoPtr and exposes functions for the source terms to be called when assembling the equations.


In the end, this approach is similar to what the fvModels do.
I did not find a solution that creates less overhead.